Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test tox installation on pre-installed python #81

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

addyess
Copy link
Member

@addyess addyess commented Aug 23, 2024

Overview

Allow a github job to specify its own version of python to use, and use tox from that environment to run the tests


Details

If the github runner already has python installed via a previous step -- say:

      - name: Set up Python
        uses: actions/setup-python@v5
        with:
          python-version: '3.8'

then, this action should be able to use python-3.8 to install tox -- but it doesn't. It ignores it and uses apt to install tox.

This change tests the environment for an already installed tox or already installed pip to use for installing tox at a specific version.

  • You'll also notice the tests folder expects charmcraft 2.x/stable in order to build the ubuntu charm.

Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@addyess addyess merged commit 5193238 into main Aug 23, 2024
31 of 32 checks passed
@addyess addyess deleted the akd/input/tox-version branch August 23, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants